Pass ignoreErrors=true to more resolveEntityName callers by jakebailey · Pull Request #61144 · microsoft/TypeScript

jakebailey · 2025-02-07T21:18:23Z

In addition to the ones in getSymbolOfNameOrPropertyAccessExpression (which fix the above issue), I looked at other places we don't pass ignoreErrors=true to resolveEntityName and also fixed a pair which are only called via the public API of the TypeChecker.

There are a small handful of other ones I have not changed as I believe they are really there to report errors.

…ession

jakebailey · 2025-02-07T21:21:55Z

@typescript-bot pack this
@typescript-bot test it

typescript-bot · 2025-02-07T21:21:59Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-07T21:26:09Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164752/artifacts?artifactName=tgz&fileId=0225747C8AD14ECDEA81F4DAC6BDCF17DA8E79769C2EF0DE9C4D25753BF0B36302&fileName=/typescript-5.8.0-insiders.20250207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-61144-2".;

typescript-bot · 2025-02-07T21:43:18Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61144/merge:

Everything looks good!

typescript-bot · 2025-02-07T21:45:07Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-07T22:03:07Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,646k (± 0.04%)}	_{195,948k (± 0.79%)}	_~	_192,791k	_196,715k	_{p=0.575 n=6}
_{Parse Time}	_{1.60s (± 1.09%)}	_{1.61s (± 0.78%)}	_~	_1.59s	_1.63s	_{p=0.440 n=6}
_{Bind Time}	_{0.89s (± 1.42%)}	_{0.88s (± 1.55%)}	_~	_0.86s	_0.90s	_{p=0.408 n=6}
_{Check Time}	_{11.73s (± 0.66%)}	_{11.71s (± 0.34%)}	_~	_11.66s	_11.76s	_{p=0.629 n=6}
_{Emit Time}	_{3.29s (± 0.72%)}	_{3.37s (± 3.68%)}	_~	_3.25s	_3.55s	_{p=0.222 n=6}
_{Total Time}	_{17.52s (± 0.55%)}	_{17.57s (± 0.82%)}	_~	_17.44s	_17.77s	_{p=0.629 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,265k (± 0.01%)}	_{1,224,338k (± 0.01%)}	_~	_1,224,252k	_1,224,460k	_{p=0.093 n=6}
_{Parse Time}	_{8.04s (± 0.77%)}	_{8.04s (± 0.44%)}	_~	_7.99s	_8.07s	_{p=0.686 n=6}
_{Bind Time}	_{2.28s (± 0.53%)}	_{2.28s (± 0.75%)}	_~	_2.26s	_2.30s	_{p=0.934 n=6}
_{Check Time}	_{37.94s (± 0.47%)}	_{37.90s (± 0.57%)}	_~	_37.61s	_38.21s	_{p=0.810 n=6}
_{Emit Time}	_{18.26s (± 0.51%)}	_{18.35s (± 0.29%)}	_~	_18.28s	_18.42s	_{p=0.126 n=6}
_{Total Time}	_{66.52s (± 0.22%)}	_{66.57s (± 0.33%)}	_~	_66.33s	_66.88s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,372,446	_2,372,446	_~	_~	_~	_{p=1.000 n=6}
_Types	_846,261	_846,261	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,135,072k (± 0.01%)}	_{2,135,008k (± 0.01%)}	_~	_2,134,888k	_2,135,221k	_{p=0.230 n=6}
_{Parse Time}	_{8.85s (± 1.82%)}	_{8.84s (± 2.13%)}	_~	_8.73s	_9.22s	_{p=0.685 n=6}
_{Bind Time}	_{2.84s (± 7.10%)}	_{2.86s (± 7.51%)}	_~	_2.42s	_2.97s	_{p=0.470 n=6}
_{Check Time}	_{87.83s (± 2.11%)}	_{87.99s (± 2.04%)}	_~	_86.79s	_91.62s	_{p=0.336 n=6}
_{Emit Time}	_{0.20s (± 5.79%)}	_{0.19s (± 4.22%)}	_~	_0.18s	_0.20s	_{p=0.131 n=6}
_{Total Time}	_{99.73s (± 1.81%)}	_{99.88s (± 1.78%)}	_~	_98.63s	_103.46s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,511	_1,228,511	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,725,670k (±14.60%)}	_{2,968,193k (± 9.99%)}	_~	_2,362,031k	_3,090,325k	_{p=0.298 n=6}
_{Parse Time}	_{6.64s (± 2.14%)}	_{6.72s (± 0.88%)}	_~	_6.60s	_6.76s	_{p=1.000 n=6}
_{Bind Time}	_{2.14s (± 2.26%)}	_{2.15s (± 1.57%)}	_~	_2.10s	_2.20s	_{p=0.872 n=6}
_{Check Time}	_{42.64s (± 0.52%)}	_{42.66s (± 0.43%)}	_~	_42.37s	_42.91s	_{p=1.000 n=6}
_{Emit Time}	_{3.47s (± 3.49%)}	_{3.43s (± 2.18%)}	_~	_3.34s	_3.54s	_{p=0.873 n=6}
_{Total Time}	_{54.91s (± 0.64%)}	_{54.96s (± 0.47%)}	_~	_54.45s	_55.18s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,511	_1,228,511	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,912,589k (±12.85%)}	_{3,033,976k (± 9.76%)}	_~	_2,429,167k	_3,155,698k	_{p=0.173 n=6}
_{Parse Time}	_{6.91s (± 1.36%)}	_{6.94s (± 1.06%)}	_~	_6.81s	_7.01s	_{p=0.575 n=6}
_{Bind Time}	_{2.13s (± 1.16%)}	_{2.12s (± 1.14%)}	_~	_2.09s	_2.15s	_{p=0.520 n=6}
_{Check Time}	_{42.63s (± 0.35%)}	_{42.76s (± 0.48%)}	_~	_42.40s	_42.94s	_{p=0.298 n=6}
_{Emit Time}	_{3.47s (± 1.41%)}	_{3.43s (± 1.69%)}	_~	_3.38s	_3.51s	_{p=0.375 n=6}
_{Total Time}	_{55.16s (± 0.45%)}	_{55.25s (± 0.54%)}	_~	_54.72s	_55.49s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,817	_262,817	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,833	_106,833	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,521k (± 0.01%)}	_{440,467k (± 0.02%)}	_~	_440,351k	_440,574k	_{p=0.298 n=6}
_{Parse Time}	_{3.55s (± 1.03%)}	_{3.56s (± 1.10%)}	_~	_3.51s	_3.61s	_{p=0.748 n=6}
_{Bind Time}	_{1.31s (± 0.57%)}	_{1.32s (± 0.88%)}	_~	_1.30s	_1.33s	_{p=0.097 n=6}
_{Check Time}	_{18.91s (± 0.31%)}	_{18.98s (± 0.30%)}	_{+0.07s (+ 0.34%)}	_18.87s	_19.04s	_{p=0.045 n=6}
_{Emit Time}	_{1.53s (± 0.76%)}	_{1.51s (± 0.54%)}	_{-0.02s (- 1.20%)}	_1.50s	_1.52s	_{p=0.016 n=6}
_{Total Time}	_{25.30s (± 0.36%)}	_{25.37s (± 0.25%)}	_~	_25.26s	_25.43s	_{p=0.170 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,285k (± 0.01%)}	_{371,270k (± 0.01%)}	_~	_371,206k	_371,337k	_{p=0.689 n=6}
_{Parse Time}	_{2.32s (± 0.85%)}	_{2.32s (± 0.88%)}	_~	_2.30s	_2.34s	_{p=0.869 n=6}
_{Bind Time}	_{1.34s (± 1.68%)}	_{1.35s (± 2.06%)}	_~	_1.32s	_1.38s	_{p=0.402 n=6}
_{Check Time}	_{13.68s (± 0.35%)}	_{13.70s (± 0.37%)}	_~	_13.63s	_13.78s	_{p=0.465 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.33s (± 0.32%)}	_{17.37s (± 0.31%)}	_~	_17.29s	_17.42s	_{p=0.373 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,284,782	_3,284,782	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,129,428	_1,129,428	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,351,612k (± 0.01%)}	_{3,351,455k (± 0.00%)}	_~	_3,351,333k	_3,351,656k	_{p=0.093 n=6}
_{Parse Time}	_{11.93s (± 0.35%)}	_{11.96s (± 0.34%)}	_~	_11.90s	_12.02s	_{p=0.336 n=6}
_{Bind Time}	_{3.83s (± 0.55%)}	_{3.82s (± 0.51%)}	_~	_3.79s	_3.84s	_{p=0.250 n=6}
_{Check Time}	_{75.54s (± 0.38%)}	_{75.28s (± 0.47%)}	_~	_74.93s	_75.86s	_{p=0.230 n=6}
_{Emit Time}	_{23.38s (± 0.35%)}	_{23.33s (± 0.30%)}	_~	_23.22s	_23.41s	_{p=0.574 n=6}
_{Total Time}	_{114.68s (± 0.34%)}	_{114.40s (± 0.36%)}	_~	_113.97s	_115.01s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,381	_293,381	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,582	_119,582	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{446,890k (± 0.02%)}	_{446,919k (± 0.02%)}	_~	_446,843k	_447,081k	_{p=0.810 n=6}
_{Parse Time}	_{4.08s (± 0.77%)}	_{4.07s (± 1.00%)}	_~	_4.03s	_4.14s	_{p=0.572 n=6}
_{Bind Time}	_{1.78s (± 0.94%)}	_{1.79s (± 1.15%)}	_~	_1.76s	_1.81s	_{p=0.251 n=6}
_{Check Time}	_{18.74s (± 0.54%)}	_{18.80s (± 0.27%)}	_~	_18.75s	_18.86s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.59s (± 0.45%)}	_{24.66s (± 0.36%)}	_~	_24.57s	_24.80s	_{p=0.521 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,375	_555,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,024k (± 0.03%)}	_{494,058k (± 0.01%)}	_~	_493,980k	_494,138k	_{p=0.689 n=6}
_{Parse Time}	_{3.42s (± 0.71%)}	_{3.41s (± 0.78%)}	_~	_3.37s	_3.45s	_{p=0.743 n=6}
_{Bind Time}	_{1.20s (± 1.70%)}	_{1.20s (± 1.05%)}	_~	_1.19s	_1.22s	_{p=1.000 n=6}
_{Check Time}	_{19.68s (± 1.34%)}	_{19.57s (± 0.34%)}	_~	_19.51s	_19.65s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.29s (± 1.09%)}	_{24.18s (± 0.29%)}	_~	_24.10s	_24.27s	_{p=0.375 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-07T22:57:32Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61144/merge:

Everything looks good!

jakebailey added 3 commits February 7, 2025 13:03

Consistently pass ignoreErrors in getSymbolOfNameOrPropertyAccessExpr…

59a31a4

…ession

And another one

9e40fdc

Do some more public API ones

65da4e6

jakebailey requested review from DanielRosenwasser, RyanCavanaugh and weswigham February 7, 2025 21:18

jakebailey mentioned this pull request Feb 7, 2025

Memory leakage occurs in the getTypeAtLocation method in the latest version. #61008

Closed

1 task

DanielRosenwasser approved these changes Feb 10, 2025

View reviewed changes

jakebailey merged commit e1629e5 into microsoft:main Feb 10, 2025
32 checks passed

jakebailey deleted the fix-61008 branch February 10, 2025 17:26

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 15, 2025

typescript-bot assigned jakebailey Oct 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass ignoreErrors=true to more resolveEntityName callers#61144

Pass ignoreErrors=true to more resolveEntityName callers#61144
jakebailey merged 3 commits intomicrosoft:mainfrom
jakebailey:fix-61008

jakebailey commented Feb 7, 2025

Uh oh!

jakebailey commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Feb 7, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025

tsc

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jakebailey commented Feb 7, 2025

Uh oh!

jakebailey commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

typescript-bot commented Feb 7, 2025

tsc

Uh oh!

typescript-bot commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Feb 7, 2025 •

edited

Loading

typescript-bot commented Feb 7, 2025 •

edited

Loading